Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed breaking change in minor bump of 'mime' package. #1998

Merged
merged 1 commit into from
May 17, 2019

Conversation

tonyanziano
Copy link
Contributor

Changelog Entry

Description

While running npm audit on the Emulator for compliance, the installed version of mime was bumped to 2.4.3 which contains a breaking change for mime-wrapper.js in Web Chat.

The old code used to require type definitions from .json files:

  require('mime/types/standard.json'),
  require('mime/types/other.json')

but these files were changed to .js files in a recent update.

This was breaking the Emulator as well when trying to build and webpack Web Chat.

Specific Changes

  • bumped mime to 2.4.3
  • changed require() statements to pull from .js files instead of .json

@tonyanziano tonyanziano force-pushed the toanzian/mime-bump branch from eb64601 to b06cdfc Compare May 17, 2019 00:57
@corinagum corinagum merged commit 0768267 into master May 17, 2019
@corinagum corinagum deleted the toanzian/mime-bump branch May 17, 2019 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants