Added JsCreatePromise to JsRT #2594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I figured out how to rebase #2581, closing this one. |
jianchun
approved these changes
Feb 24, 2017
akroshg
reviewed
Feb 24, 2017
| *resolve = nullptr; | ||
| *reject = nullptr; | ||
|
|
||
| Js::JavascriptPromiseResolveOrRejectFunction *jsResolve; |
There was a problem hiding this comment.
nit: initialize this values with nullptr.
There was a problem hiding this comment.
I just pushed it, but I'll fix it. I assume I should do the second one as well?
chakrabot
pushed a commit
that referenced
this pull request
Feb 24, 2017
chakrabot
pushed a commit
that referenced
this pull request
Feb 25, 2017
Merge pull request #2594 from kfarnung:jsrtpromise2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retargeted the change to release/2.0