Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17-07 ChakraCore servicing release #3341

Merged
merged 12 commits into from
Jul 13, 2017
Merged

17-07 ChakraCore servicing release #3341

merged 12 commits into from
Jul 13, 2017

Conversation

akroshg
Copy link
Contributor

@akroshg akroshg commented Jul 13, 2017

akroshg and others added 9 commits July 10, 2017 16:43
… invalid index

Pre-reserve potentially needed slots upfront.
…re conversion of the source value can cause implicit calls. For BailOutOnImplicitCalls, check implicit call bit on return from the conversion helper. For BailOutOnArrayAccessHelperCall, bail out instead of calling the conversion helper.
…en new pointer symbol and existing object type spec info. If there is a mismatch, then stale ObjTypeSpecFldInfo may lead to jitted code that accesses a bad address, so disable optimization of this load/store.
…erpreter

Prevents having to use the interpreterStackFrame outside of InterpreterHelper
@akroshg
Copy link
Contributor Author

akroshg commented Jul 13, 2017

@rajatd @suwc @Cellule @pleath @jianchun Please have a look

@akroshg
Copy link
Contributor Author

akroshg commented Jul 13, 2017

@Penguinwizzard @kfarnung FYI...

@suwc
Copy link

suwc commented Jul 13, 2017

LGTM. [CVE-2017-8598]

@jianchun
Copy link

LGTM (8606, 8607, 8608)

@Cellule
Copy link
Contributor

Cellule commented Jul 13, 2017

LGTM [CVE-2017-8603] [CVE-2017-8604]

@rajatd
Copy link
Contributor

rajatd commented Jul 13, 2017

LGTM wrt CVE-2017-8610

@MSLaguana
Copy link
Contributor

Looks like there's an asmjs test failure on osx, and some prefast warnings on windows, in addition to copyright/line ending complaints.

@akroshg
Copy link
Contributor Author

akroshg commented Jul 13, 2017

@MSLaguana yes working on it.

@pleath
Copy link
Contributor

pleath commented Jul 13, 2017 via email

@akroshg
Copy link
Contributor Author

akroshg commented Jul 13, 2017

@pleath yes.
looking at OSX problem now.

@akroshg
Copy link
Contributor Author

akroshg commented Jul 13, 2017

For asmJs @Cellule can you take a look?

@Cellule
Copy link
Contributor

Cellule commented Jul 13, 2017

We should add exclude_xplat to my new asm.js test. It is hitting issue #2378

@chakrabot chakrabot merged commit 9940903 into release/1.5 Jul 13, 2017
chakrabot pushed a commit that referenced this pull request Jul 13, 2017
@akroshg
Copy link
Contributor Author

akroshg commented Jul 13, 2017

Thanks guys!

chakrabot pushed a commit that referenced this pull request Jul 13, 2017
chakrabot pushed a commit that referenced this pull request Jul 13, 2017
chakrabot pushed a commit that referenced this pull request Jul 13, 2017
@rajatd rajatd mentioned this pull request Jul 14, 2017
@obastemur obastemur deleted the pr/akroshg/1707 branch January 30, 2018 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants