Enable inlining into functions which have try-catch/try-finally #3832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meg-gupta
force-pushed
the
tryinline
branch
from
932131e
to
ea8c518
Compare
|
@dotnet-bot test this please |
|
There are issues that need to be worked in the stack walker, I will reopen once they are fixed. |
meg-gupta
force-pushed
the
tryinline
branch
4 times, most recently
from
ef3ef3a
to
d2e0a4e
Compare
|
@dotnet-bot dotnet-bot Linked test this please |
meg-gupta
force-pushed
the
tryinline
branch
5 times, most recently
from
e5a6c57
to
d119260
Compare
rajatd
reviewed
Oct 6, 2017
rajatd
reviewed
Oct 6, 2017
lib/Runtime/Language/EHBailoutData.h
Outdated
|
|
||
| public: | ||
| EHBailoutData() : nestingDepth(-1), catchOffset(0), finallyOffset(0), parent(nullptr), child(nullptr), ht(HT_None) {} | ||
| EHBailoutData() : nestingDepth(-1), catchOffset(0), finallyOffset(0), parent(nullptr), child(nullptr), ht(HT_None), inlineeCode(nullptr) {} |
There was a problem hiding this comment.
nullptr [](start = 137, length = 7)
init to false?
rajatd
reviewed
Oct 6, 2017
rajatd
reviewed
Oct 10, 2017
rajatd
reviewed
Oct 10, 2017
|
@rajatd Addressed review comments |
rajatd
approved these changes
Oct 11, 2017
- Avoid copy prop s0 (return symbol) into inlined functions - Clear inlinee callinfo : When there is an exception in an inlinee which is inside an EH region, we end up leaving datastructures in stackwalker dirty. If the EH handler was a try catch, and if the same code is executed in a loop in the interprerter after BailOnNoException, the stack walker due to dirty datastructures assumes that there are inlinee frames on the stack.
chakrabot
pushed a commit
that referenced
this pull request
Oct 12, 2017
…y-catch/try-finally Merge pull request #3832 from meg-gupta:tryinline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.