-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for VS2013 (dev12) #3855
Conversation
Don't forget to remove the CI trigger definitions for dev12. |
The CI builds are defined based on the netci.groovy script in that branch. If we leave that target there in an older branch, then (as long as we still care to track that branch, which is defined elsewhere) it'll keep the definition and run it when PRs are made. |
I've added another commit to remove dev12 from the netci.groovy file. Remaining failures will be resolved when CI fix PR #3854 gets pumped up and this PR gets rebased. |
This change removes support for Visual Studio 2013. Doing this will afford us the use of a much wider set of constructs in C++, as more recent versions of Visual Studio provide full support for C++11. I'm going to leave this PR open for a week (at least) to invite any comments about the change that may be out there. Note: Although this change is to move to support C++11, we could be a C++14 code base with little extra effort; our minimum versions of clang (3.9) and VS (dev14) are both sufficient for C++14 support. I think the only thing holding that back is that we may want to allow a 4.9 version of GCC.
With the removal of Dev12 (VS 2013) support, we no longer need (nor want) Dev12 builds in CI.
809a45b
to
d24e902
Compare
Merge pull request #3855 from Penguinwizzard:version_bump This change removes support for Visual Studio 2013. Doing this will afford us the use of a much wider set of constructs in C++, as more recent versions of Visual Studio provide full support for C++11. I'm going to leave this PR open for a week (at least) to invite any comments about the change that may be out there. Note: Although this change is to move to support C++11, we could be a C++14 code base with little extra effort; our minimum versions of clang (3.9) and VS (dev14) are both sufficient for C++14 support. I think the only thing holding that back is that we may want to allow a 4.9 version of GCC.
Do we still want a Win7 build with Dev14 (since we still claim to support building and running on Win7)? Should we make Dev14 on Server 2012 R2 the legacy build and move to Dev15 on Server 2016 for the primary Windows CI checks? |
We do want a Dev14 build; I'm not sure about whether Win7 or Server 2012 R2 is more used in the community though. |
Server 2012 R2 is roughly equivalent to win8.1, so I think Win7 is more likely to find issues due to old OS. For example, we use an API for pdata registration that is different on win7 vs. win8+. |
Yes, I may have misspoken. For our purposes:
Legacy builds used (Dev12 on 2008 R2) We could update so that:
Or something similar. Basically we want to support the following configs with a minimal matrix: { Dev15, Dev14 } x { Server 2016, 2012 R2, 2008 R2 } |
…p VS2013 support in README Merge pull request #3925 from liminzhu:readme Per chakra-core/ChakraCore#3855
This change removes support for Visual Studio 2013. Doing this will
afford us the use of a much wider set of constructs in C++, as more
recent versions of Visual Studio provide full support for C++11.
I'm going to leave this PR open for a week (at least) to invite any
comments about the change that may be out there.
Note: Although this change is to move to support C++11, we could be
a C++14 code base with little extra effort; our minimum versions of
clang (3.9) and VS (dev14) are both sufficient for C++14 support. I
think the only thing holding that back is that we may want to allow
a 4.9 version of GCC.