Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for VS2013 (dev12) #3855

Merged
merged 2 commits into from
Oct 10, 2017

Conversation

Penguinwizzard
Copy link
Contributor

This change removes support for Visual Studio 2013. Doing this will
afford us the use of a much wider set of constructs in C++, as more
recent versions of Visual Studio provide full support for C++11.

I'm going to leave this PR open for a week (at least) to invite any
comments about the change that may be out there.

Note: Although this change is to move to support C++11, we could be
a C++14 code base with little extra effort; our minimum versions of
clang (3.9) and VS (dev14) are both sufficient for C++14 support. I
think the only thing holding that back is that we may want to allow
a 4.9 version of GCC.

@Cellule
Copy link
Contributor

Cellule commented Oct 3, 2017

Don't forget to remove the CI trigger definitions for dev12.
@dilijev Is it possible to keep the dev12 build only for older releases or should we just drop it completely ?

@MSLaguana
Copy link
Contributor

The CI builds are defined based on the netci.groovy script in that branch. If we leave that target there in an older branch, then (as long as we still care to track that branch, which is defined elsewhere) it'll keep the definition and run it when PRs are made.

@Penguinwizzard
Copy link
Contributor Author

I've added another commit to remove dev12 from the netci.groovy file. Remaining failures will be resolved when CI fix PR #3854 gets pumped up and this PR gets rebased.

This change removes support for Visual Studio 2013. Doing this will
afford us the use of a much wider set of constructs in C++, as more
recent versions of Visual Studio provide full support for C++11.

I'm going to leave this PR open for a week (at least) to invite any
comments about the change that may be out there.

Note: Although this change is to move to support C++11, we could be
a C++14 code base with little extra effort; our minimum versions of
clang (3.9) and VS (dev14) are both sufficient for C++14 support. I
think the only thing holding that back is that we may want to allow
a 4.9 version of GCC.
With the removal of Dev12 (VS 2013) support, we no longer need (nor
want) Dev12 builds in CI.
@chakrabot chakrabot merged commit d24e902 into chakra-core:master Oct 10, 2017
chakrabot pushed a commit that referenced this pull request Oct 10, 2017
Merge pull request #3855 from Penguinwizzard:version_bump

This change removes support for Visual Studio 2013. Doing this will
afford us the use of a much wider set of constructs in C++, as more
recent versions of Visual Studio provide full support for C++11.

I'm going to leave this PR open for a week (at least) to invite any
comments about the change that may be out there.

Note: Although this change is to move to support C++11, we could be
a C++14 code base with little extra effort; our minimum versions of
clang (3.9) and VS (dev14) are both sufficient for C++14 support. I
think the only thing holding that back is that we may want to allow
a 4.9 version of GCC.
@dilijev
Copy link
Contributor

dilijev commented Oct 10, 2017

Do we still want a Win7 build with Dev14 (since we still claim to support building and running on Win7)?

Should we make Dev14 on Server 2012 R2 the legacy build and move to Dev15 on Server 2016 for the primary Windows CI checks?

@Penguinwizzard
Copy link
Contributor Author

We do want a Dev14 build; I'm not sure about whether Win7 or Server 2012 R2 is more used in the community though.

@MikeHolman
Copy link
Contributor

Server 2012 R2 is roughly equivalent to win8.1, so I think Win7 is more likely to find issues due to old OS. For example, we use an API for pdata registration that is different on win7 vs. win8+.

@dilijev
Copy link
Contributor

dilijev commented Oct 12, 2017

Yes, I may have misspoken. For our purposes:

  1. Server 2008 R2 ~= Windows 7
  2. Server 2012 R2 ~= Windows 8.1
  3. Server 2016 = Windows 10 (unsure of a build correspondence)

Legacy builds used (Dev12 on 2008 R2)
Current builds use (Dev14 on 2012 R2)

We could update so that:

  • Current builds use (Dev15 on 2016)
  • "Compat" builds (reduced matrix) on (Dev14 on 2012 R2) -- or (Dev14 + 2016)
  • Legacy = (Dev14 on 2008 R2)

Or something similar.

Basically we want to support the following configs with a minimal matrix: { Dev15, Dev14 } x { Server 2016, 2012 R2, 2008 R2 }

chakrabot pushed a commit that referenced this pull request Oct 12, 2017
Merge pull request #3925 from liminzhu:readme

Per #3855
chakrabot added a commit to nodejs/node-chakracore that referenced this pull request Oct 13, 2017
…p VS2013 support in README

Merge pull request #3925 from liminzhu:readme

Per chakra-core/ChakraCore#3855
@Penguinwizzard Penguinwizzard deleted the version_bump branch March 21, 2018 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants