Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsrt: Add JavascriptSymbol support to JsObject Get/Has/Set etc.. #4209

Merged
merged 3 commits into from
Nov 14, 2017

Conversation

obastemur
Copy link
Collaborator

Also;

  • native-tests: automated static test folder discovery
  • native-test: JsObject Get/Has/Set etc. symbol support testing

Copy link
Contributor

@boingoing boingoing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@obastemur
Copy link
Collaborator Author

@boingoing Thanks for the review

@chakrabot chakrabot merged commit 27ada66 into chakra-core:master Nov 14, 2017
chakrabot pushed a commit that referenced this pull request Nov 14, 2017
…ct Get/Has/Set etc..

Merge pull request #4209 from obastemur:support_symbol

Also;

 - native-tests: automated static test folder discovery
 - native-test: JsObject Get/Has/Set etc. symbol support testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants