Fix for -break-insert main returning multiple bind points #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmaybee
approved these changes
Jun 11, 2018
|
@paulmaybee I tried converting them but sometimes the results come back as a string and not as a Result, so I thought best to leave it the way it is at this point. |
WardenGnaw
approved these changes
Jun 11, 2018
| { | ||
| this._entryPointBreakpoint = dict["number"]; | ||
| bkpt = (b as ValueListValue).Content[0] as TupleValue; |
There was a problem hiding this comment.
Can you add a comment here describing when this will get used?
|
|
||
| if (bkpt != null) | ||
| { | ||
| this._entryPointBreakpoint = bkpt.FindString("number"); |
There was a problem hiding this comment.
Does GDB do the .1 thing with number in the multiple bind case? If so, do we need to do anything else to pre-process the number before we send it to breakpoint delete?
|
@gregg-miskelly From other instances where we use this method, the Content[0] index will return the parent breakpoint of |
This fix is to support -break-insert main returning multiple bind points, which was causing a dictionary error on multiple keys.
pieandcakes
force-pushed
the
users/piel/breakMainFix
branch
from
34f85fa
to
cc41cf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is to support -break-insert main returning multiple bind
points, which was causing a dictionary error on multiple keys.
Fix for: microsoft/vscode-cpptools#2056
@paulmaybee Can you verify that this change won't break your use cases?