Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RunInTerminalResponse may not have a responseBody #810

Merged
merged 1 commit into from
Nov 27, 2018
Merged

RunInTerminalResponse may not have a responseBody #810

merged 1 commit into from
Nov 27, 2018

Conversation

pieandcakes
Copy link
Collaborator

  • Update variable name and add null check before operating on the
    responseBody

Fixes: microsoft/vscode-cpptools#2858

@pieandcakes
RunInTerminalResponse may not have a responseBody
2ef9478 
* Update variable name and add null check before operating on the
responseBody
@pieandcakes pieandcakes self-assigned this Nov 27, 2018
@pieandcakes
Copy link
Collaborator Author

@WardenGnaw verified that it fixes the issue.

@pieandcakes pieandcakes merged commit 3d2b0e6 into master Nov 27, 2018
@WardenGnaw WardenGnaw mentioned this pull request Dec 11, 2018
Merged
@pieandcakes pieandcakes deleted the users/piel/fixNullReference branch January 25, 2019 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregg-miskelly gregg-miskelly gregg-miskelly approved these changes

@WardenGnaw WardenGnaw WardenGnaw approved these changes

Assignees

@pieandcakes pieandcakes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pieandcakes @WardenGnaw @gregg-miskelly