Support for --jsxFactory option #12135
Conversation
…alid combinations
| @@ -2250,6 +2251,7 @@ namespace ts { | |||
| /* @internal */ | |||
| export interface TypeCheckerHost { | |||
| getCompilerOptions(): CompilerOptions; | |||
| getJsxFactoryEntity(): EntityName; | |||
There was a problem hiding this comment.
this feels odd. i would rather we parsed the jsxFactory string one more time in the checker instead.
…ue in the program
|
Do we still need typescript@next for this? https://github.com/Microsoft/TypeScript/wiki/Roadmap says it's landed, but I'm seeing in 2.1.1. |
|
Thanks for the clarification. I'm not sure the roadmap makes that clear. The heading "2.1 (November 2016)" reads like those features have already shipped in 2.1.0, especially since they have little checkmarks next to them. Someone would have to scroll all the way to the bottom to realize the checkmarks are meant to connote "next" features. Moreover, the PR linked from the Roadmap doesn't have a version label/milestone attached to it. |
|
At the bottom of the roadmap page, there is an explanation that the checkmark means it is available in |
|
did not mean to sound pedantic. just wanted to make sure the process is clear. questions are always welcomed. |
|
I saw that, but only after your first response. It never occurred to me to scroll to the bottom of the page until you said "The roadmap says it is in Have you considered putting the checkbox descriptor at the top? How about making your roadmap more granular (e.g. change the Nov heading to 2.1.1: stable and have a heading above it for next)? I don't mean to be nit picky, but I'm sure I'm not the last person who will misread the current Roadmap. |
|
thanks for the tip. moved the note to the top. and will consider having better naming for milestones in the future. |
Fixes #9582 and #12067