Make ScriptElementKind and HighlightSpanKind string enums #15966
Conversation
ghost
src/services/types.ts
Outdated
|
|
||
| /** | ||
| * <JsxTagName attribute1 attribute2={0} /> | ||
| */ | ||
| export const jsxAttribute = "JSX attribute"; | ||
| jsxAttribute = "JSX attribute", | ||
| } | ||
|
|
||
| export namespace ScriptElementKindModifier { |
There was a problem hiding this comment.
should also change ScriptElementKindModifier to be an enum.
There was a problem hiding this comment.
and ClassificationTypeNames
src/services/types.ts
Outdated
|
|
||
| /** | ||
| * <JsxTagName attribute1 attribute2={0} /> | ||
| */ | ||
| export const jsxAttribute = "JSX attribute"; | ||
| jsxAttribute = "JSX attribute", | ||
| } | ||
|
|
||
| export namespace ScriptElementKindModifier { |
There was a problem hiding this comment.
and ClassificationTypeNames
src/services/types.ts
Outdated
|
|
||
| /** | ||
| * <JsxTagName attribute1 attribute2={0} /> | ||
| */ | ||
| export const jsxAttribute = "JSX attribute"; | ||
| jsxAttribute = "JSX attribute", | ||
| } | ||
|
|
||
| export namespace ScriptElementKindModifier { |
src/services/types.ts
Outdated
|
|
||
| /** | ||
| * <JsxTagName attribute1 attribute2={0} /> | ||
| */ | ||
| export const jsxAttribute = "JSX attribute"; | ||
| jsxAttribute = "JSX attribute", | ||
| } | ||
|
|
||
| export namespace ScriptElementKindModifier { |
|
Also please add a note for this in https://github.com/Microsoft/TypeScript/wiki/API-Breaking-Changes#typescript-24 |
mhegazy
added
Breaking Change
|
@mhegazy Is there any reason to avoid a non- |
src/server/protocol.ts
Outdated
| @@ -2,103 +2,103 @@ | |||
| * Declaration module describing the TypeScript Server protocol | |||
| */ | |||
| namespace ts.server.protocol { | |||
| export namespace CommandTypes { | |||
| export type Brace = "brace"; | |||
| export enum CommandTypes { | |||
There was a problem hiding this comment.
this should be const enum, since it does not exist at time of building the client against the protocol file.
There was a problem hiding this comment.
We need to iterate over it though -- I guess I could define a CommandTypes[] elsewhere but we'd have to remember to update both places every time a new command is added.
| export namespace NewLineKind { | ||
| export type Crlf = "Crlf"; | ||
| export type Lf = "Lf"; | ||
| export const enum NewLineKind { |
There was a problem hiding this comment.
missing the initialization here.
yes. protocol.ts compiles down to so either we make them const in |
Note: is technically a change to our public API as many
strings are nowScriptElementKinds. And anyone using the API must now have ts@next or they will get compile errors on the string enums -- but presumably people compiling against the ts@next API are compiling using ts@next too.Required running
gulp LKGto get #15486 in.