Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make getSuggestion APIs internal. #25520

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Make getSuggestion APIs internal. #25520

merged 1 commit into from
Jul 10, 2018

Conversation

DanielRosenwasser
Copy link
Member

Fixes #25519.

@DanielRosenwasser
Copy link
Member Author

FWIW, searching GitHub with TSQuery seemed to only bring up forks of TypeScript.

https://bigtsquery.firebaseapp.com/query?selector=CallExpression%3EPropertyAccessExpression%5Bname.name%3DgetSuggestionForNonexistentProperty%5D

CallExpression>PropertyAccessExpression[name.name=getSuggestionForNonexistentExport]

@mhegazy mhegazy added Breaking Change Would introduce errors in existing code API Relates to the public API for TypeScript labels Jul 9, 2018
@mhegazy mhegazy added this to the TypeScript 3.0 milestone Jul 9, 2018
@mhegazy
Copy link
Contributor

mhegazy commented Jul 9, 2018

Please add a note about this change in https://github.com/Microsoft/TypeScript/wiki/API-Breaking-Changes

@DanielRosenwasser DanielRosenwasser merged commit 3dd1d25 into master Jul 10, 2018
@mhegazy mhegazy deleted the internalizeNonexistentHelpers branch July 10, 2018 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhegazy mhegazy mhegazy approved these changes

Assignees
No one assigned
Labels
API Relates to the public API for TypeScript Breaking Change Would introduce errors in existing code
Projects
None yet
Milestone
TypeScript 3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielRosenwasser @mhegazy