Add HamburgerVisibility property #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deltakosh
reviewed
Mar 9, 2017
| @@ -54,6 +54,7 @@ | |||
| DisplayMode="@[DisplayMode:Enum:SplitViewDisplayMode.CompactInline]" | |||
| CompactPaneLength="@[CompactPaneLength:Slider:48:10-80]" | |||
| HamburgerHeight="@[HamburgerHeight:Slider:48:10-80]" | |||
| HamburgerVisibility="@[HamburgerVisibility:Enum:Visibility.Visible]" | |||
There was a problem hiding this comment.
I would call it HamburgerButtonVisibility to avoid misunderstandings
There was a problem hiding this comment.
@deltakosh That was my first idea as well. But then I saw that all other properties of the hamburger button only have the "Hamburger" prefix (HamburgerHeight, HamburgerWidth, HamburgerMargin, they all affect the button and not the icon itself). So for having naming consistency, I chose to use "HamburgerVisibility". But I agree that HamburgerButtonVisibility is the better name. Shall I change it?
There was a problem hiding this comment.
You are completely right. We can keep like it then :)
deltakosh
approved these changes
Mar 10, 2017
Odonno
approved these changes
Mar 11, 2017
punker76
added a commit
to MahApps/MahApps.Metro
that referenced
this pull request
Mar 28, 2017
punker76
added a commit
to MahApps/MahApps.Metro
that referenced
this pull request
Mar 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the HamburgerVisibility property as discussed in #1019.