Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update PR template for PR title naming convention. #1263

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

v-viyada
Copy link
Contributor

Details

semantic-release uses PR title for deciding release version and it follows https://www.conventionalcommits.org/en/v1.0.0/. It is required to have terminal colon and space. So added this in PR checklist to verify PR title before merging it.

Motivation
Context

Pull request checklist

  • PR title respects Conventional Commits (starts with fix:, feat:, etc, and is suitable for user-facing release notes)
  • PR contains no breaking changes, OR description of both PR and final merge commit starts with BREAKING CHANGE:
  • (if applicable) Addresses issue: #0000
  • Added relevant unit tests for your changes
  • Ran yarn precheckin
  • Verified code coverage for the changes made

@v-viyada v-viyada marked this pull request as ready for review March 28, 2024 21:25
@v-viyada v-viyada requested a review from a team as a code owner March 28, 2024 21:25
@v-viyada v-viyada merged commit 3e6fd3d into main Apr 3, 2024
4 checks passed
@v-viyada v-viyada deleted the users/v-viyada/document-update branch April 3, 2024 20:19
@ada-cat
Copy link
Collaborator

ada-cat commented Jun 27, 2024

🎉 This PR is included in version 2.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants