This repository has been archived by the owner on Nov 5, 2021. It is now read-only.
csharp: add support for binary literals and _ as separator #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought about giving the binary literal its own theme, but that would require changes in vscode and I wasn't sure if it's worth it. Should the theme be extended to support styling hex and binary literals differently? https://github.com/Microsoft/vscode/blob/1.11.2/src/vs/editor/common/standalone/themes.ts#L25 |
Note that proper `_` usage is not enforced; this matches vscode behavior.
|
Updated to add some corresponding test cases. |
|
Thank you @sandyarmstrong ! ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that proper
_usage is not enforced; this matches vscode behavior.