Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test | Add test to validate microsoft.sql.DateTimeOffset interchangeable behavior #1005

Merged
merged 4 commits into from
Apr 8, 2019

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented Mar 23, 2019

Open for more use-cases to capture any wrong computations done by driver when sending data to SQL Server's DateTimeOffset column.

@codecov-io
Copy link

codecov-io commented Mar 23, 2019

Codecov Report

Merging #1005 into dev will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev    #1005      +/-   ##
============================================
- Coverage     50.13%   50.06%   -0.08%     
+ Complexity     2882     2875       -7     
============================================
  Files           120      120              
  Lines         27989    27989              
  Branches       4677     4677              
============================================
- Hits          14032    14012      -20     
- Misses        11700    11724      +24     
+ Partials       2257     2253       -4
Flag Coverage Δ Complexity Δ
#JDBC42 49.64% <ø> (-0.1%) 2835 <ø> (-10)
#JDBC43 50% <ø> (-0.08%) 2872 <ø> (-5)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 52.23% <0%> (-1.5%) 11% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerException.java 76.64% <0%> (-1.46%) 32% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 46.22% <0%> (-1.08%) 110% <0%> (-2%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 43.56% <0%> (-0.31%) 315% <0%> (-3%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 68.24% <0%> (-0.24%) 0% <0%> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.41% <0%> (+0.03%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84484ed...fe3b9ed. Read the comment docs.

@cheenamalhotra cheenamalhotra merged commit a1a004e into microsoft:dev Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants