-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SQLServerDatabaseMetadata.getMaxConnections() API query #1009
Merged
cheenamalhotra
merged 11 commits into
microsoft:dev
from
cheenamalhotra:fixGetMaxConnections
May 14, 2019
Merged
Fix SQLServerDatabaseMetadata.getMaxConnections() API query #1009
cheenamalhotra
merged 11 commits into
microsoft:dev
from
cheenamalhotra:fixGetMaxConnections
May 14, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1009 +/- ##
===========================================
- Coverage 53% 52.94% -0.06%
+ Complexity 3149 3140 -9
===========================================
Files 119 119
Lines 27943 27947 +4
Branches 4668 4671 +3
===========================================
- Hits 14811 14797 -14
- Misses 10911 10921 +10
- Partials 2221 2229 +8
Continue to review full report at Codecov.
|
peterbae
reviewed
Apr 8, 2019
src/test/java/com/microsoft/sqlserver/jdbc/databasemetadata/DatabaseMetaDataTest.java
Outdated
Show resolved
Hide resolved
peterbae
previously approved these changes
Apr 8, 2019
rene-ye
previously approved these changes
Apr 8, 2019
rene-ye
previously approved these changes
Apr 8, 2019
peterbae
previously approved these changes
Apr 8, 2019
lilgreenbird
previously approved these changes
Apr 8, 2019
ulvii
reviewed
Apr 17, 2019
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java
Outdated
Show resolved
Hide resolved
cheenamalhotra
dismissed stale reviews from lilgreenbird, peterbae, and rene-ye
via
April 17, 2019 23:57
6cc07a8
peterbae
previously approved these changes
Apr 25, 2019
ulvii
reviewed
Apr 25, 2019
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java
Outdated
Show resolved
Hide resolved
ulvii
reviewed
Apr 25, 2019
rene-ye
previously approved these changes
Apr 29, 2019
peterbae
previously approved these changes
May 10, 2019
lilgreenbird
previously approved these changes
May 13, 2019
# Conflicts: # src/test/java/com/microsoft/sqlserver/jdbc/SQLServerConnectionTest.java
cheenamalhotra
dismissed stale reviews from lilgreenbird, peterbae, and rene-ye
via
May 13, 2019 19:08
9dfa996
peterbae
approved these changes
May 13, 2019
rene-ye
approved these changes
May 14, 2019
ulvii
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently driver was using
sp_configure
to fetch 'user connections' configuration which is not correct way to do it. Also with SQL Server 2019, this configuration is moved to 'Advanced Options' hence cannot be run directly as with older SQL Servers.This PR modifies the query and executes SELECT from
sys.configurations
which is the recommended way for gathering metadata information.