Binary and Varbinary types for framework #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-nisidh
reviewed
Jan 16, 2017
| @@ -251,16 +253,22 @@ String populateTableSql() { | |||
| for (int colNum = 0; colNum < totalColumns; colNum++) { | |||
|
|
|||
| // TODO: add betterway to enclose data | |||
| if (JDBCType.CHAR == getColumn(colNum).getSqlType().getJdbctype() | |||
| if (JDBCType.CHAR == getColumn(colNum).getSqlType().getJdbctype() | |||
There was a problem hiding this comment.
Suggestion: Can we have one utility method to get JDBCType
public JDBCType getJDBCType(DBColumn column) {
return column.getSqlType().getJdbcType();
}
```
There was a problem hiding this comment.
ya, that sounds good.
v-nisidh
reviewed
Jan 16, 2017
| || JDBCType.VARCHAR == getColumn(colNum).getSqlType().getJdbctype() | ||
| || JDBCType.NCHAR == getColumn(colNum).getSqlType().getJdbctype() | ||
| || JDBCType.NVARCHAR == getColumn(colNum).getSqlType().getJdbctype() | ||
| || JDBCType.TIMESTAMP == getColumn(colNum).getSqlType().getJdbctype() | ||
| || JDBCType.DATE == getColumn(colNum).getSqlType().getJdbctype() | ||
| || JDBCType.TIME == getColumn(colNum).getSqlType().getJdbctype()) | ||
| || JDBCType.TIME == getColumn(colNum).getSqlType().getJdbctype()) { |
There was a problem hiding this comment.
SUGGESTION: In order to reduce complexity it is better to create new method having all conditions and call that method in your if condition.
If method is reusable then you can move this method to Util class. Otherwise create this helper method in same class.
added 2 commits
January 17, 2017 13:22
v-nisidh
approved these changes
Jan 18, 2017
|
|
||
| import java.sql.JDBCType; | ||
| import java.util.concurrent.ThreadLocalRandom; | ||
|
|
There was a problem hiding this comment.
Can you add appropriate java docs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for binary and varbinary type.
The new files have same header as the rest of test framework, we can apply the changes throughout the source once header format is finalized.