Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove java.io.Serializable interface from SQLServerConnectionPoolProxy. #201

Conversation

xiangyushawn
Copy link
Contributor

for issue #190

@codecov-io
Copy link

Codecov Report

Merging #201 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev     #201      +/-   ##
============================================
- Coverage     32.83%   32.83%   -0.01%     
- Complexity     1428     1430       +2     
============================================
  Files            97       97              
  Lines         23359    23359              
  Branches       3881     3881              
============================================
- Hits           7670     7669       -1     
- Misses        14148    14152       +4     
+ Partials       1541     1538       -3
Flag Coverage Δ Complexity Δ
#JDBC41 32.73% <ø> (ø) 1425 <ø> (+1)
#JDBC42 32.78% <ø> (+0.01%) 1430 <ø> (+4)
Impacted Files Coverage Δ Complexity Δ
...t/sqlserver/jdbc/SQLServerConnectionPoolProxy.java 12.62% <ø> (ø) 12 <0> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 24.55% <0%> (-0.45%) 39% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 44.94% <0%> (-0.08%) 181% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 36.34% <0%> (-0.07%) 0% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 23.92% <0%> (+0.08%) 171% <0%> (+1%)
src/main/java/microsoft/sql/DateTimeOffset.java 40% <0%> (+2.85%) 10% <0%> (+2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e24866c...4832373. Read the comment docs.

@v-nisidh v-nisidh self-requested a review March 16, 2017 18:30
@v-nisidh v-nisidh merged commit b352610 into microsoft:dev Mar 21, 2017
@xiangyushawn xiangyushawn deleted the non-serializable-SQLServerConnectionPoolProxy branch March 21, 2017 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants