Allow using multiple JAAS configurations and override the configuration per connection properties #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on per connection properties. We also set a different default LoginConfig for IBM JVM, so it should work well with user-provided passwords and username for Kerberos. Should solve microsoft#66 for IBM JVM.
Codecov Report
@@ Coverage Diff @@
## dev #254 +/- ##
============================================
- Coverage 34.34% 34.33% -0.01%
+ Complexity 1553 1548 -5
============================================
Files 101 102 +1
Lines 23656 23644 -12
Branches 3878 3870 -8
============================================
- Hits 8124 8119 -5
+ Misses 13936 13928 -8
- Partials 1596 1597 +1
Continue to review full report at Codecov.
|
v-nisidh
added
Work in Progress
…esouchay/mssql-jdbc into pierresouchay-multiple_jaas_config_names
|
Thanks @pierresouchay! Commits that were already in the dev branch got added to this PR when I submitted few changes. Can you rebase the code? I for some reason don't have permission. |
|
@v-suhame DONE |
Suraiya-Hameed
approved these changes
Apr 26, 2017
|
Perfect! Thanks for contributing @pierresouchay! |
|
@v-suhame cool! Does it solves #66 with IBM JVM? |
|
Yes, it did solve #66 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also set a different default LoginConfig for IBM JVM, so it should work well with user-provided
passwords and username for Kerberos.
Should solve #66 for IBM JVM.