Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct javadocs #354

Merged
merged 3 commits into from
Jun 26, 2017
Merged

Correct javadocs #354

merged 3 commits into from
Jun 26, 2017

Conversation

ahmad-ibra
Copy link

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 21, 2017

Codecov Report

Merging #354 into RTW_6.2.0 will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             RTW_6.2.0     #354      +/-   ##
===============================================
- Coverage        40.05%   39.99%   -0.06%     
+ Complexity        1878     1877       -1     
===============================================
  Files              107      107              
  Lines            24480    24480              
  Branches          4036     4036              
===============================================
- Hits              9805     9791      -14     
- Misses           12838    12844       +6     
- Partials          1837     1845       +8
Flag Coverage Δ Complexity Δ
#JDBC41 39.87% <ø> (-0.05%) 1868 <ø> (-3)
#JDBC42 39.87% <ø> (-0.09%) 1870 <ø> (-5)
Impacted Files Coverage Δ Complexity Δ
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 41.45% <ø> (ø) 129 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 45.24% <ø> (ø) 268 <0> (ø) ⬇️
...l/googlecode/concurrentlinkedhashmap/Weighers.java 8.51% <ø> (ø) 1 <0> (ø) ⬇️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 42.2% <ø> (ø) 46 <0> (ø) ⬇️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 47.27% <0%> (-0.46%) 63% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 27.23% <0%> (-0.42%) 187% <0%> (-4%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 44.68% <0%> (-0.31%) 0% <0%> (ø)
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java 28.89% <0%> (-0.23%) 46% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 29.21% <0%> (-0.23%) 56% <0%> (ø)
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 44.94% <0%> (ø) 16% <0%> (ø) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33814db...695436e. Read the comment docs.

@v-nisidh v-nisidh requested a review from xiangyushawn June 22, 2017 00:57
* The default for this option can be changed by calling getDefaultServerPreparedStatementDiscardThreshold().
* Returns the behavior for a specific connection instance. This setting controls how many outstanding prepared statement discard actions
* (sp_unprepare) can be outstanding per connection before a call to clean-up the outstanding handles on the server is executed. If the setting is
* less than or equal to 1, unprepare actions will be executed immedietely on prepared statement close. If it is set to more than 1, these calls
Copy link
Contributor

@xiangyushawn xiangyushawn Jun 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also use @literal here? everything else looks good to me

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@ahmad-ibra ahmad-ibra merged commit ec418e0 into microsoft:RTW_6.2.0 Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants