-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing connection property - fipsProvider #460
Conversation
@ulvii, |
Codecov Report
@@ Coverage Diff @@
## dev #460 +/- ##
===========================================
- Coverage 46.3% 46.23% -0.07%
+ Complexity 2198 2196 -2
===========================================
Files 108 108
Lines 25260 25244 -16
Branches 4176 4172 -4
===========================================
- Hits 11696 11672 -24
- Misses 11542 11551 +9
+ Partials 2022 2021 -1
Continue to review full report at Codecov.
|
if (logger.isLoggable(Level.FINER)) | ||
logger.finer(toString() + " FIPS provider & TrustStoreType should pass with TrustStore."); | ||
logger.finer(toString() + "TrustStoreType is requiered alongside with TrustStore."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/requiered/required/
@@ -72,32 +71,12 @@ public void fipsEncryptTest() throws Exception { | |||
} | |||
catch (SQLServerException e) { | |||
Assertions.assertTrue( | |||
e.getMessage().contains("Could not enable FIPS due to either encrypt is not true or using trusted certificate settings."), | |||
e.getMessage().contains("Unable to verify FIPS mode settings."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest getting these same String error messages from SQLServerResource.java in test cases, such that your code becomes:
e.getMessage().contains(SQLServerResource.getResource("R_invalidFipsConfig"), "Some..").
It would remove all possibilities of errors and add maintainability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getResource()
is not a public API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah.. I missed that, in that case we need a custom resource bundle for our test framework. I have created issue #466 to track this change.
@@ -52,8 +52,7 @@ public void fipsTrustServerCertificateTest() throws Exception { | |||
} | |||
catch (SQLServerException e) { | |||
Assertions.assertTrue( | |||
e.getMessage().contains("Could not enable FIPS due to either encrypt is not true or using trusted certificate settings."), | |||
"Should create exception for invalid TrustServerCertificate value"); | |||
e.getMessage().contains("Unable to verify FIPS mode settings.")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any specific reason for removing "Should create exception for invalid TrustServerCertificate value"
from line 56?
Based on the discussions on #433 and #438.