Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit extends object #469

Merged
merged 1 commit into from
Sep 21, 2017

Conversation

JamieMagee
Copy link
Member

All objects in Java implicity extend java.lang.Object so extends Object is redundant.

Removing it will reduce confusion, and increase code readability.

All objects in Java implicity extend `java.lang.Object` so `extends Object` is redundant.

Removing it will reduce confusion, and increase code readability.
@codecov-io
Copy link

codecov-io commented Sep 1, 2017

Codecov Report

Merging #469 into dev will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #469      +/-   ##
============================================
+ Coverage     46.26%   46.27%   +0.01%     
- Complexity     2201     2204       +3     
============================================
  Files           108      108              
  Lines         25227    25227              
  Branches       4172     4172              
============================================
+ Hits          11672    11675       +3     
+ Misses        11538    11526      -12     
- Partials       2017     2026       +9
Flag Coverage Δ Complexity Δ
#JDBC41 46.03% <0%> (-0.04%) 2193 <1> (+1)
#JDBC42 46.12% <0%> (+0.01%) 2193 <1> (-4) ⬇️
Impacted Files Coverage Δ Complexity Δ
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.88% <ø> (+0.53%) 0 <0> (ø) ⬇️
src/main/java/microsoft/sql/Types.java 0% <ø> (ø) 0 <0> (ø) ⬇️
src/main/java/microsoft/sql/DateTimeOffset.java 41.42% <0%> (ø) 11 <1> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 44.94% <0%> (-2.25%) 16% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 43.14% <0%> (-1.8%) 104% <0%> (ø)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 62.23% <0%> (-0.43%) 63% <0%> (-1%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.94% <0%> (-0.29%) 242% <0%> (-2%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 62.99% <0%> (-0.25%) 0% <0%> (ø)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 42.2% <0%> (-0.22%) 46% <0%> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.77% <0%> (+0.12%) 241% <0%> (+2%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a13577...180dff0. Read the comment docs.

@ajlam ajlam modified the milestone: 6.3.3 Sep 5, 2017
@cheenamalhotra cheenamalhotra merged commit 8b261f9 into microsoft:dev Sep 21, 2017
@JamieMagee JamieMagee deleted the explicit-extends-object branch September 22, 2017 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants