-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added cancelQueryTimeout to cancel QueryTimeout on Connection and Statement #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n IOBuffer for tcpkeepaliveTimer
Codecov Report
@@ Coverage Diff @@
## dev #674 +/- ##
============================================
- Coverage 48.22% 48.18% -0.05%
+ Complexity 2579 2578 -1
============================================
Files 113 113
Lines 26569 26626 +57
Branches 4438 4449 +11
============================================
+ Hits 12813 12829 +16
- Misses 11619 11656 +37
- Partials 2137 2141 +4
Continue to review full report at Codecov.
|
ulvii
reviewed
May 1, 2018
ulvii
reviewed
May 1, 2018
ulvii
reviewed
May 1, 2018
ulvii
reviewed
May 1, 2018
ulvii
reviewed
May 1, 2018
ulvii
reviewed
May 1, 2018
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
…ilent connection drops - Minor fixes | GitHub issue 525
Hi @ulvii - made recommended fixes. Please review once more. Thanks! |
ulvii
reviewed
May 2, 2018
ulvii
reviewed
May 2, 2018
…ut connection property | GitHub issue microsoft#525
ulvii
approved these changes
May 2, 2018
rene-ye
approved these changes
May 2, 2018
AfsanehR-zz
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension of PR #560.
Adds new property cancelQueryTimeout on both Connection and Statement classes. The Connection level property is used by all statements by default, while setting it at Statement level overrides the connection property.
The fix will address issue #525 where queryTimeout hangs and does not throw exception due to silent dropping of TCP connection.
The driver now reads timeout values from statement being executed and not connection (Changed from #560 initial implementation) and shall wait the total amount of cancelQueryTimeout + queryTimeout to drop the connection and close the channel.
Note: The new connection property of cancelQueryTimeout will be effective only if the queryTimeout is set in the driver.