Fix issues with apostrophe being passed in table name + Improvements in SQLServerParameterMetadata #780

cheenamalhotra · 2018-08-08T23:58:35Z

Fixes issue SQLServerBulkCopy / getDestinationMetadata fails when there's an apostrophe in the table name #775
Fixes Null Pointer Exception reported in Executing a PreparedStatement with SET SHOWPLAN_ALL ON or SET SHOWPLAN_XML ON does not return a ResultSet. #778
Updates Junit tests to test apostrophe(') in randomized table name

codecov-io · 2018-08-09T00:31:30Z

Codecov Report

Merging #780 into dev will not change coverage.
The diff coverage is 37.16%.

@@            Coverage Diff            @@
##                dev     #780   +/-   ##
=========================================
  Coverage     48.53%   48.53%           
- Complexity     2806     2810    +4     
=========================================
  Files           116      116           
  Lines         27862    27862           
  Branches       4641     4647    +6     
=========================================
  Hits          13523    13523           
- Misses        12197    12206    +9     
+ Partials       2142     2133    -9

Flag	Coverage Δ	Complexity Δ
#JDBC42	`48.06% <37.16%> (+0.41%)`	`2770 <1> (+34)`	⬆️
#JDBC43	`48.09% <37.16%> (-0.35%)`	`2777 <1> (-24)`

Impacted Files	Coverage Δ	Complexity Δ
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java	`52.03% <100%> (-0.08%)`	`216 <0> (ø)`
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java	`61.63% <100%> (+0.08%)`	`92 <1> (+1)`	⬆️
...oft/sqlserver/jdbc/SQLServerParameterMetaData.java	`24.56% <32.35%> (+0.36%)`	`31 <0> (ø)`	⬇️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java	`52.6% <80%> (-0.01%)`	`261 <0> (-1)`
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java	`45.05% <0%> (-3.3%)`	`16% <0%> (ø)`
...m/microsoft/sqlserver/jdbc/SQLServerException.java	`77.27% <0%> (-1.52%)`	`32% <0%> (-1%)`
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java	`44.63% <0%> (-1.1%)`	`106% <0%> (-1%)`
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java	`62.92% <0%> (-0.81%)`	`64% <0%> (ø)`
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java	`55.93% <0%> (-0.14%)`	`0% <0%> (ø)`
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 550d441...5c687ed. Read the comment docs.

…cks (Fixes issue microsoft#778)

…metadata

src/main/java/com/microsoft/sqlserver/jdbc/SQLServerPreparedStatement.java

ulvii · 2018-09-18T23:53:26Z

src/main/java/com/microsoft/sqlserver/jdbc/Util.java

+     *        Object name to be passed as String
+     * @return Converted object name
+     */
+    static String escapeQuotes(String name) {


Can we rename this method to escapeSingleQuotes?

lilgreenbird · 2018-09-19T00:24:56Z

...test/java/com/microsoft/sqlserver/jdbc/preparedStatement/BatchExecutionWithBulkCopyTest.java

-    static String doubleQuoteTableName = "\"peter\"\"\"\"test" + UUID + "\"";
+    static String unsupportedTableName = "[BulkCopyUnsupportedTable'" + UUID + "]";
+    static String squareBracketTableName = "[peter]]]]test'" + UUID + "]";
+    static String doubleQuoteTableName = "\"peter\"\"\"\"test'" + UUID + "\"";



remove peter