Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SSL certificate validation respect wildcards #836

Merged
merged 38 commits into from
Jan 2, 2019

Conversation

peterbae
Copy link
Contributor

@peterbae peterbae commented Oct 18, 2018

Fixes issue #816.

Previously, we needed to use hostNameInCertificate when attempting to make SSL connections to Azure servers because the * (wildcard) character in the SSL certificate from Azure was being processed literally. This change makes it so that the wildcard is actually respected as "any characters".

@codecov-io
Copy link

codecov-io commented Oct 19, 2018

Codecov Report

Merging #836 into dev will decrease coverage by 0.1%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #836      +/-   ##
============================================
- Coverage     50.17%   50.07%   -0.11%     
+ Complexity     2919     2912       -7     
============================================
  Files           120      120              
  Lines         28085    28112      +27     
  Branches       4688     4695       +7     
============================================
- Hits          14093    14077      -16     
- Misses        11711    11750      +39     
- Partials       2281     2285       +4
Flag Coverage Δ Complexity Δ
#JDBC42 49.65% <0%> (ø) 2874 <0> (+3) ⬆️
#JDBC43 50.01% <0%> (-0.03%) 2909 <0> (-4)
Impacted Files Coverage Δ Complexity Δ
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.76% <0%> (-0.44%) 0 <0> (ø)
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 52.94% <0%> (-1.48%) 11% <0%> (-1%)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39% <0%> (-0.44%) 43% <0%> (-2%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 66.66% <0%> (-0.3%) 0% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 48.15% <0%> (-0.22%) 112% <0%> (ø)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 66.13% <0%> (-0.21%) 64% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 42.89% <0%> (-0.2%) 311% <0%> (-3%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 51.55% <0%> (-0.13%) 256% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a14861...bfa48c6. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.1.3 milestone Nov 20, 2018
cheenamalhotra
cheenamalhotra previously approved these changes Nov 21, 2018
@cheenamalhotra cheenamalhotra removed this from the 7.1.3 milestone Nov 29, 2018
@ulvii ulvii added this to the 7.1.4 milestone Dec 3, 2018
@cheenamalhotra
Copy link
Member

@peterbae Please pull changes from PR peterbae#7

Copy link
Member

@cheenamalhotra cheenamalhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting changes.

cheenamalhotra
cheenamalhotra previously approved these changes Jan 2, 2019
rene-ye
rene-ye previously approved these changes Jan 2, 2019
@peterbae peterbae dismissed stale reviews from rene-ye and cheenamalhotra via bfa48c6 January 2, 2019 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants