-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SSL certificate validation respect wildcards #836
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #836 +/- ##
============================================
- Coverage 50.17% 50.07% -0.11%
+ Complexity 2919 2912 -7
============================================
Files 120 120
Lines 28085 28112 +27
Branches 4688 4695 +7
============================================
- Hits 14093 14077 -16
- Misses 11711 11750 +39
- Partials 2281 2285 +4
Continue to review full report at Codecov.
|
src/test/java/com/microsoft/sqlserver/jdbc/SSLCertificateValidation.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/SSLCertificateValidation.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/SSLCertificateValidation.java
Outdated
Show resolved
Hide resolved
…thub-816 # Conflicts: # src/main/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
src/test/java/com/microsoft/sqlserver/jdbc/SSLCertificateValidation.java
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/SSLCertificateValidation.java
Outdated
Show resolved
Hide resolved
… also make sure wildcard is not allowed in top domain
@peterbae Please pull changes from PR peterbae#7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awaiting changes.
A different proposal for wildcard certificate matching
Fixes issue #816.
Previously, we needed to use hostNameInCertificate when attempting to make SSL connections to Azure servers because the * (wildcard) character in the SSL certificate from Azure was being processed literally. This change makes it so that the wildcard is actually respected as "any characters".