Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change scope of Connection/Statement in test to prevent random failures #862

Merged
merged 4 commits into from
Nov 21, 2018

Conversation

cheenamalhotra
Copy link
Member

Test fails randomly due to shared objects in tests which get closed due to race conditions.
This PR makes sure Connection and Statement are always dedicated and open while executing a single test.

@codecov-io
Copy link

codecov-io commented Oct 29, 2018

Codecov Report

Merging #862 into dev will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #862      +/-   ##
============================================
+ Coverage     48.67%   48.74%   +0.06%     
- Complexity     2793     2804      +11     
============================================
  Files           116      116              
  Lines         27875    27877       +2     
  Branches       4650     4650              
============================================
+ Hits          13569    13589      +20     
+ Misses        12099    12087      -12     
+ Partials       2207     2201       -6
Flag Coverage Δ Complexity Δ
#JDBC42 48.3% <ø> (+0.14%) 2762 <ø> (+14) ⬆️
#JDBC43 48.61% <ø> (+0.04%) 2794 <ø> (+3) ⬆️
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 44.2% <0%> (-1.76%) 107% <0%> (ø)
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java 34.84% <0%> (-0.08%) 66% <0%> (ø)
...oft/sqlserver/jdbc/SQLServerParameterMetaData.java 24.56% <0%> (-0.06%) 31% <0%> (ø)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 64.32% <0%> (ø) 64% <0%> (ø) ⬇️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 56.17% <0%> (+0.01%) 0% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 59.57% <0%> (+0.05%) 135% <0%> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 52.97% <0%> (+0.17%) 264% <0%> (+1%) ⬆️
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 79.48% <0%> (+0.19%) 5% <0%> (+1%) ⬆️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.11% <0%> (+0.42%) 260% <0%> (+5%) ⬆️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 61.42% <0%> (+0.43%) 90% <0%> (+1%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f097cd...bcdb3d0. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.1.3 milestone Nov 20, 2018
peterbae
peterbae previously approved these changes Nov 21, 2018
ulvii
ulvii previously approved these changes Nov 21, 2018
@cheenamalhotra cheenamalhotra merged commit 597319f into microsoft:dev Nov 21, 2018
ulvii pushed a commit that referenced this pull request Nov 30, 2018
ulvii added a commit that referenced this pull request Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants