-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change scope of Connection/Statement in test to prevent random failures #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #862 +/- ##
============================================
+ Coverage 48.67% 48.74% +0.06%
- Complexity 2793 2804 +11
============================================
Files 116 116
Lines 27875 27877 +2
Branches 4650 4650
============================================
+ Hits 13569 13589 +20
+ Misses 12099 12087 -12
+ Partials 2207 2201 -6
Continue to review full report at Codecov.
|
peterbae
previously approved these changes
Nov 21, 2018
ulvii
previously approved these changes
Nov 21, 2018
peterbae
approved these changes
Nov 21, 2018
ulvii
pushed a commit
that referenced
this pull request
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test fails randomly due to shared objects in tests which get closed due to race conditions.
This PR makes sure Connection and Statement are always dedicated and open while executing a single test.