-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address TODOs in tests #873
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #873 +/- ##
===========================================
- Coverage 48.98% 48.68% -0.3%
+ Complexity 2821 2796 -25
===========================================
Files 116 116
Lines 27877 27877
Branches 4650 4650
===========================================
- Hits 13655 13573 -82
+ Misses 12104 12098 -6
- Partials 2118 2206 +88
Continue to review full report at Codecov.
|
src/test/java/com/microsoft/sqlserver/jdbc/datatypes/TVPWithSqlVariantTest.java
Show resolved
Hide resolved
ulvii
reviewed
Nov 26, 2018
src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyColumnMappingTest.java
Outdated
Show resolved
Hide resolved
ulvii
reviewed
Nov 26, 2018
src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyTestUtil.java
Show resolved
Hide resolved
ulvii
reviewed
Nov 26, 2018
src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyTestUtil.java
Outdated
Show resolved
Hide resolved
peterbae
approved these changes
Nov 28, 2018
cheenamalhotra
approved these changes
Nov 28, 2018
ulvii
pushed a commit
that referenced
this pull request
Nov 30, 2018
* address TODOs * rename var * rename var * comments only * review udpates * more review updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed/addressed/created backlog on TODOs