-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix random issue for SQLFloat random NaN value and improved TVPAllTypesTest for possible errors. #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fixed error possibilities in TVPAllTypesTest
Codecov Report
@@ Coverage Diff @@
## dev #888 +/- ##
============================================
- Coverage 48.72% 48.72% -0.01%
- Complexity 2799 2814 +15
============================================
Files 116 118 +2
Lines 27877 27863 -14
Branches 4650 4637 -13
============================================
- Hits 13584 13575 -9
- Misses 12088 12092 +4
+ Partials 2205 2196 -9
Continue to review full report at Codecov.
|
src/test/java/com/microsoft/sqlserver/jdbc/tvp/TVPAllTypesTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/tvp/TVPAllTypesTest.java
Outdated
Show resolved
Hide resolved
peterbae
previously approved these changes
Nov 23, 2018
peterbae
previously approved these changes
Nov 23, 2018
lilgreenbird
previously approved these changes
Nov 23, 2018
cheenamalhotra
dismissed stale reviews from lilgreenbird and peterbae
via
November 26, 2018 20:55
d4539c3
ulvii
approved these changes
Nov 26, 2018
peterbae
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.