-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround Bulk Copy for batch insert operation against specific datatypes. #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #912 +/- ##
============================================
+ Coverage 50.17% 50.43% +0.25%
- Complexity 2919 2929 +10
============================================
Files 120 120
Lines 28085 28117 +32
Branches 4688 4696 +8
============================================
+ Hits 14093 14180 +87
+ Misses 11711 11637 -74
- Partials 2281 2300 +19
Continue to review full report at Codecov.
|
lilgreenbird
reviewed
Jan 2, 2019
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerBulkBatchInsertRecord.java
Outdated
Show resolved
Hide resolved
lilgreenbird
reviewed
Jan 2, 2019
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerPreparedStatement.java
Outdated
Show resolved
Hide resolved
lilgreenbird
reviewed
Jan 2, 2019
...test/java/com/microsoft/sqlserver/jdbc/preparedStatement/BatchExecutionWithBulkCopyTest.java
Outdated
Show resolved
Hide resolved
lilgreenbird
reviewed
Jan 2, 2019
...test/java/com/microsoft/sqlserver/jdbc/preparedStatement/BatchExecutionWithBulkCopyTest.java
Outdated
Show resolved
Hide resolved
lilgreenbird
reviewed
Jan 2, 2019
...test/java/com/microsoft/sqlserver/jdbc/preparedStatement/BatchExecutionWithBulkCopyTest.java
Show resolved
Hide resolved
rene-ye
reviewed
Jan 2, 2019
...test/java/com/microsoft/sqlserver/jdbc/preparedStatement/BatchExecutionWithBulkCopyTest.java
Outdated
Show resolved
Hide resolved
lilgreenbird
reviewed
Jan 3, 2019
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerBulkBatchInsertRecord.java
Show resolved
Hide resolved
lilgreenbird
reviewed
Jan 3, 2019
lilgreenbird
reviewed
Jan 3, 2019
...test/java/com/microsoft/sqlserver/jdbc/preparedStatement/BatchExecutionWithBulkCopyTest.java
Show resolved
Hide resolved
lilgreenbird
reviewed
Jan 3, 2019
...test/java/com/microsoft/sqlserver/jdbc/preparedStatement/BatchExecutionWithBulkCopyTest.java
Outdated
Show resolved
Hide resolved
Add | randomizing expected values and refactoring the test
rene-ye
previously approved these changes
Jan 4, 2019
lilgreenbird
approved these changes
Jan 4, 2019
rene-ye
approved these changes
Jan 4, 2019
cheenamalhotra
approved these changes
Jan 4, 2019
rPraml
added a commit
to FOCONIS/ebean
that referenced
this pull request
Feb 3, 2019
rbygrave
pushed a commit
to ebean-orm/ebean
that referenced
this pull request
Feb 3, 2019
* FIX: mysql index sizes * FIX: osolete whitespace in sqlserver tests * Updated mssql-jdbc, this fixes problems in the batch insert (microsoft/mssql-jdbc#912) * fix tablename (reserved word in mariadb) * ignored failing tests for sqlserver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, these datatypes don't seem to work against Azure DW when using bulk copy:
Money/Smallmoney
Temporal data types (Date, Datetime, Datetime2, SmallDateTime, DateTimeOffset, Time).
This PR puts a workaround that makes tables with those columns present fallback to the original batch insert operation.
Also, Binary/Varbinary data types also used to fail, but I fixed that part in this PR as well.