Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Improvements + Readme changes #919

Merged
merged 8 commits into from
Jan 4, 2019

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented Jan 3, 2019

  • Reduces execution time of junit tests by 2 mins
  • Cleans tests to close all connections
  • Updates to Readme file

@codecov-io
Copy link

codecov-io commented Jan 3, 2019

Codecov Report

Merging #919 into dev will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #919      +/-   ##
============================================
+ Coverage     50.46%   50.47%   +0.01%     
  Complexity     2935     2935              
============================================
  Files           120      120              
  Lines         28112    28112              
  Branches       4695     4695              
============================================
+ Hits          14186    14189       +3     
+ Misses        11634    11633       -1     
+ Partials       2292     2290       -2
Flag Coverage Δ Complexity Δ
#JDBC42 50.04% <ø> (-0.01%) 2897 <ø> (ø)
#JDBC43 50.36% <ø> (-0.01%) 2930 <ø> (-1)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 52.94% <0%> (-1.48%) 11% <0%> (-1%)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 61.77% <0%> (-0.44%) 89% <0%> (-1%)
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 79.68% <0%> (-0.2%) 5% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 51.55% <0%> (-0.13%) 256% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.59% <0%> (-0.1%) 0% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 68.59% <0%> (+0.05%) 0% <0%> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 43.58% <0%> (+0.19%) 315% <0%> (+2%) ⬆️
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39% <0%> (+0.21%) 43% <0%> (ø) ⬇️
...soft/sqlserver/jdbc/SQLServerPooledConnection.java 70.52% <0%> (+1.05%) 19% <0%> (+1%) ⬆️
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 47.28% <0%> (+1.08%) 112% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a5e216...27155b1. Read the comment docs.

rene-ye
rene-ye previously approved these changes Jan 3, 2019
@cheenamalhotra cheenamalhotra added this to the 7.1.4 milestone Jan 4, 2019
@cheenamalhotra cheenamalhotra merged commit fc24284 into microsoft:dev Jan 4, 2019
@cheenamalhotra cheenamalhotra deleted the readme branch February 5, 2019 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants