Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SonarQube issues #930

Merged
merged 2 commits into from
Jan 11, 2019
Merged

Fix SonarQube issues #930

merged 2 commits into from
Jan 11, 2019

Conversation

peterbae
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 10, 2019

Codecov Report

Merging #930 into dev will increase coverage by 0.38%.
The diff coverage is 30.43%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #930      +/-   ##
============================================
+ Coverage     49.96%   50.34%   +0.38%     
- Complexity     2893     2927      +34     
============================================
  Files           119      120       +1     
  Lines         28096    28100       +4     
  Branches       4694     4693       -1     
============================================
+ Hits          14037    14147     +110     
+ Misses        11757    11655     -102     
+ Partials       2302     2298       -4
Flag Coverage Δ Complexity Δ
#JDBC42 49.88% <30.43%> (-0.08%) 2887 <0> (-6)
#JDBC43 50.3% <30.43%> (?) 2927 <0> (?)
Impacted Files Coverage Δ Complexity Δ
...m/microsoft/sqlserver/jdbc/KeyVaultCredential.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.58% <0%> (+0.19%) 0 <0> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/KerbAuthentication.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerDataTable.java 65.87% <100%> (+0.79%) 29 <0> (ø) ⬇️
...a/com/microsoft/sqlserver/jdbc/ParameterUtils.java 64.44% <100%> (ø) 20 <0> (ø) ⬇️
...va/com/microsoft/sqlserver/jdbc/SQLServerClob.java 35.18% <25%> (-0.4%) 12 <0> (ø)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 51.47% <33.33%> (+0.12%) 254 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 52.94% <0%> (-1.48%) 11% <0%> (-1%)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.36% <0%> (-0.65%) 42% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 46.2% <0%> (-0.44%) 111% <0%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78b1399...6a1ceb1. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.2.0 milestone Jan 10, 2019
…narqube

# Conflicts:
#	src/main/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
@peterbae peterbae merged commit 7f37996 into microsoft:dev Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants