Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements | SQLServerParameterMetadata improvements with improved code coverage #973

Merged
merged 8 commits into from
Mar 13, 2019

Conversation

cheenamalhotra
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 1, 2019

Codecov Report

Merging #973 into dev will decrease coverage by <.01%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #973      +/-   ##
============================================
- Coverage     50.58%   50.57%   -0.01%     
- Complexity     2915     2921       +6     
============================================
  Files           120      120              
  Lines         27987    27958      -29     
  Branches       4678     4672       -6     
============================================
- Hits          14156    14139      -17     
+ Misses        11535    11525      -10     
+ Partials       2296     2294       -2
Flag Coverage Δ Complexity Δ
#JDBC42 50.16% <60%> (+0.14%) 2883 <5> (+16) ⬆️
#JDBC43 50.48% <60%> (-0.04%) 2917 <5> (+3)
Impacted Files Coverage Δ Complexity Δ
...oft/sqlserver/jdbc/SQLServerParameterMetaData.java 35% <60%> (+4.08%) 48 <5> (+8) ⬆️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 45.05% <0%> (-2.2%) 15% <0%> (ø)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.36% <0%> (-1.08%) 42% <0%> (-2%)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 66.53% <0%> (-0.81%) 64% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 43.4% <0%> (-0.27%) 314% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.51% <0%> (-0.24%) 0% <0%> (ø)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 53.21% <0%> (-0.2%) 216% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 68.59% <0%> (+0.05%) 0% <0%> (ø) ⬇️
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 79.92% <0%> (+0.19%) 6% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb72f76...6504ed7. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.3.0 milestone Mar 1, 2019
@cheenamalhotra cheenamalhotra changed the title Improvements | Add Null Checks to avoid possible Null pointer exception scenarios Improvements | SQLParameterMetadata improvements with improved code coverage Mar 5, 2019
@cheenamalhotra cheenamalhotra changed the title Improvements | SQLParameterMetadata improvements with improved code coverage Improvements | SQLServerParameterMetadata improvements with improved code coverage Mar 7, 2019
@cheenamalhotra cheenamalhotra merged commit 3c4b9b4 into microsoft:dev Mar 13, 2019
@cheenamalhotra cheenamalhotra deleted the nullPointers branch March 14, 2019 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants