Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FLOAT data type for bulk copy operation using RowSet #986

Merged
merged 12 commits into from
Mar 15, 2019

Conversation

peterbae
Copy link
Contributor

Fixes issue #961

@codecov-io
Copy link

codecov-io commented Mar 12, 2019

Codecov Report

Merging #986 into dev will decrease coverage by 0.47%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #986      +/-   ##
============================================
- Coverage     50.61%   50.14%   -0.48%     
+ Complexity     2921     2880      -41     
============================================
  Files           120      120              
  Lines         27996    27989       -7     
  Branches       4681     4677       -4     
============================================
- Hits          14170    14034     -136     
- Misses        11530    11692     +162     
+ Partials       2296     2263      -33
Flag Coverage Δ Complexity Δ
#JDBC42 49.68% <33.33%> (-0.46%) 2839 <0> (-39)
#JDBC43 50.07% <33.33%> (-0.41%) 2877 <0> (-39)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 50.52% <33.33%> (-1.18%) 246 <0> (-8)
...sqlserver/jdbc/SQLServerBulkBatchInsertRecord.java 0% <0%> (-30.72%) 0% <0%> (-18%)
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java 47.16% <0%> (-6.25%) 189% <0%> (-27%)
.../microsoft/sqlserver/jdbc/SQLServerBulkCommon.java 41.66% <0%> (-5.56%) 3% <0%> (-2%)
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 58.57% <0%> (-1.19%) 33% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.45% <0%> (-0.3%) 0% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 68.3% <0%> (-0.3%) 0% <0%> (ø)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.36% <0%> (-0.22%) 42% <0%> (-1%)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java 67.13% <0%> (-0.21%) 63% <0%> (-1%)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78efb57...ff1d233. Read the comment docs.

rene-ye
rene-ye previously approved these changes Mar 12, 2019
rene-ye
rene-ye previously approved these changes Mar 13, 2019
@cheenamalhotra cheenamalhotra added this to the 7.3.0 milestone Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants