Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance | Refactor SELECT_METHOD in SQLServerConnection to improve performance #987

Merged
merged 2 commits into from
Mar 13, 2019

Conversation

peterbae
Copy link
Contributor

Fixes issue #981

@codecov-io
Copy link

codecov-io commented Mar 12, 2019

Codecov Report

Merging #987 into dev will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #987      +/-   ##
============================================
- Coverage     50.61%   50.59%   -0.02%     
+ Complexity     2921     2919       -2     
============================================
  Files           120      120              
  Lines         27996    27993       -3     
  Branches       4681     4679       -2     
============================================
- Hits          14170    14164       -6     
  Misses        11530    11530              
- Partials       2296     2299       +3
Flag Coverage Δ Complexity Δ
#JDBC42 50.15% <100%> (+0.01%) 2879 <0> (+1) ⬆️
#JDBC43 50.51% <100%> (+0.02%) 2915 <0> (-1) ⬇️
Impacted Files Coverage Δ Complexity Δ
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 46.45% <100%> (+0.01%) 342 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 52.23% <0%> (-1.5%) 11% <0%> (-1%)
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 58.57% <0%> (-1.19%) 33% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 68.47% <0%> (-0.12%) 0% <0%> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 55.68% <0%> (-0.07%) 0% <0%> (ø)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 39% <0%> (+0.43%) 43% <0%> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 45.05% <0%> (+1.09%) 15% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78efb57...d1cc78a. Read the comment docs.

@cheenamalhotra cheenamalhotra added this to the 7.3.0 milestone Mar 12, 2019
@peterbae peterbae merged commit d8adbcd into microsoft:dev Mar 13, 2019
@cheenamalhotra cheenamalhotra changed the title Refactor SELECT_METHOD in SQLServerConnection Performance | Refactor SELECT_METHOD in SQLServerConnection to improve performance May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants