feat(cli): launch-server command #5713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
reviewed
Mar 4, 2021
src/cli/driver.ts
Outdated
| @@ -53,6 +55,12 @@ export function runServer() { | |||
| new PlaywrightDispatcher(dispatcherConnection.rootDispatcher(), playwright); | |||
| } | |||
|
|
|||
| export async function launchBrowserServer(browserName: string) { | |||
| const browserType = (playwright as any)[browserName] as BrowserType; | |||
| const server = await browserType.launchServer(); | |||
There was a problem hiding this comment.
This looks good, but i would fs.readFileSync(config) and pass it here. That way user can opt into accepting downloads, respecting proxy, etc.
pavelfeldman
approved these changes
Mar 4, 2021
yury-s
force-pushed
the
launch-server-cli
branch
from
a145551 to
7aa4fcb
Compare
yury-s
added a commit
to yury-s/playwright
that referenced
this pull request
Mar 4, 2021
yury-s
added a commit
that referenced
this pull request
Mar 4, 2021
This was referenced Mar 10, 2021
Merged
Merged
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple command to run browserType.launchServer