Enable hot exit for saved files #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kburtram
reviewed
Jan 11, 2018
| @@ -267,7 +267,7 @@ configurationRegistry.registerConfiguration({ | |||
| 'files.hotExit': { | |||
| 'type': 'string', | |||
| 'enum': [HotExitConfiguration.OFF, HotExitConfiguration.ON_EXIT, HotExitConfiguration.ON_EXIT_AND_WINDOW_CLOSE], | |||
| 'default': HotExitConfiguration.ON_EXIT, | |||
| 'default': HotExitConfiguration.OFF, | |||
There was a problem hiding this comment.
I just merged your change to force off HotExit. you probably should merge that change and set it to read from the config and default to OFF.
kburtram
approved these changes
Jan 11, 2018
MattIrv
force-pushed
the
fix/hotExitFiles
branch
from
8d0e483 to
fa487d2
Compare
|
In 0.25.3, it looks like HotExit is disabled (receive save dialog when exiting and files are gone after reopening). Is this the intended behavior for now? |
|
@mrlife Hot exit is disabled by default in this build, but can be enabled in settings (ctrl + ,) by changing "files.hotExit" to "onExit" or "onExitAndWindowClose". We'll make sure to document these steps for the upcoming release. If that doesn't work for you, please let me know. Thanks! |
aleklj
pushed a commit
to aleklj/azuredatastudio
that referenced
this pull request
Oct 28, 2019
* fix file browser service bug * modify filebrowser service * change filebrowser contract * fix contract * fix file browser add/expand event contracts * remove commented code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #463 by changing how we serialize and deserialize editor windows to always serialize VS Code's version of the editor, then convert it to a
SqlInputeditor upon deserialization if needed.This is still a work in progress and needs some testing, but opening the PR now in case others are interested in looking at the code change.