Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make discovering test methods from base classes defined in another assembly the default. #164

Closed
AbhitejJohn opened this issue Apr 23, 2017 · 6 comments
Closed

Make discovering test methods from base classes defined in another assembly the default. #164

AbhitejJohn opened this issue Apr 23, 2017 · 6 comments
Labels
Type: Docs
Milestone
S119

Comments

@AbhitejJohn
Copy link
Contributor

AbhitejJohn commented Apr 23, 2017 •
edited
Loading

Pulled out from #23.

Description

We plugged in this support in the 1.1.17 version of the packages as part of #23. This should however be the default workflow even though this is a difference in behavior from MSTest V1. This should however be documented though.
@AbhitejJohn
Copy link
Contributor Author

From @AbhitejJohn

Here are the top level discovery numbers I got from VS for a solution with 9 projects each having 10 test classes each with 100 tests:

With the config enabled: 4.67 s. (average of 5 runs)
Without the config enabled: 4.76 s. (average of 5 runs)

This is on a 16 Gb, 2 core machine.

Although the numbers should ideally be reversed based on our theory above, the point is that this does not affect performance and can be turned on by default.

@AbhitejJohn
Copy link
Contributor Author

This is currently blocked by #163.

@AbhitejJohn AbhitejJohn mentioned this issue Apr 23, 2017
Closed
@AbhitejJohn AbhitejJohn mentioned this issue May 15, 2017
Merged
@jayaranigarg jayaranigarg added this to the S119 milestone May 29, 2017
@MikeChristensen
Copy link

Just checking on this one - We'd really love to see this get done! Any estimate on when this will be fixed?

@AbhitejJohn
Copy link
Contributor Author

@MikeChristensen : This feature is already available in version 1.1.18 of the Framework/Adapter tuple. Its just not the default. You can turn it on by passing in the following runsettings:

<RunSettings>    
  <MSTest> 
    <EnableBaseClassTestMethodsFromOtherAssemblies>true</EnableBaseClassTestMethodsFromOtherAssemblies> 
  </MSTest> 
</RunSettings>

@MikeChristensen
Copy link

I'm aware of this. I'm asking when it will be turned on by default, without needing a runsettings file.

@AbhitejJohn
Copy link
Contributor Author

That is scheduled for the next release - End of next week is when we are hoping to get this through.

@jayaranigarg jayaranigarg mentioned this issue Jun 21, 2017
Merged
@jayaranigarg jayaranigarg mentioned this issue Jun 29, 2017
Merged
singhsarab pushed a commit to singhsarab/testfx that referenced this issue Apr 8, 2019
@Faizan2304
Hadle exception in vstest.console (microsoft#164)
1b0ae6a 
* Issue: Discovery and execution got stuck if project under test is not having nuget reference of TestHost and targeting netcoreapp1.0

Fix:- catch the exception and raise HandleDiscoveryComplete/HandleExecutionComplte event.

Test:
1) Manually
2) Unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Docs
Projects
None yet
Milestone
S119
Development

No branches or pull requests
3 participants
@MikeChristensen @jayaranigarg @AbhitejJohn