TestMethod failures are masked by TestCleanup exceptions in the outcome.

[AbhitejJohn]

Description

Failures in the TestMethod are masked by TestCleanup exceptions in the outcome.

Steps to reproduce

1. Create an MSTest V2 based unit test project.
2. Throw an exception in the TestMethod and the TestCleanup.
3. Run the test.

Expected behavior

An indication of the test method exception and stack trace should be shown in the outcome.

Actual behavior

Only the TestCleanup stack is shown.

[AbhitejJohn]

Code that affects this change is at src\testadapter\execution\testmethodinfo.RunTestCleanupMethod().
Need to decide if this is something we want to combine or do we just want to show the testmethod exception details.

[pvlakshm]

This happens only when the TestMethod fails AND the TestCleanup method fails.

[AbhitejJohn]

Reopening this - This is both misleading and is a compat break from MSTest V1 which displays both the details. For instance with the below code

[TestMethod]
        public void TestMethod1()
        {
            Assert.Inconclusive();
        }

        [TestCleanup]
        public void TC()
        {
            throw new NullReferenceException();
        }

this is the error info in Test Explorer.

[smadala]

Customer are hitting this issue: Assembly load failures in TestInitialize() are not getting reported When there is failure in TestCleanup().

[kevintbrown]

I'd also like to add that when Debugging a single test in Visual Studio 2017, there is no exposure to the user that the [TestInitialize()] and [TestMethod()] attributed methods are even executed (you can put breakpoints at the top of each method and they are skipped).

Next thing you know an exception is thrown in [TestCleanup()], which makes it really hard to debug your underlying issue. I had to engage the MSTest team to figure out what was going on.

(Thanks again for the help!)

[smadala]

Enable logging also helps to find root cause,following blog post helps how to enable logging enable unit test execution logs