Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for [DeploymentItem] attribute #1581

Merged
merged 27 commits into from
Feb 10, 2023
Merged

Add documentation for [DeploymentItem] attribute #1581

merged 27 commits into from
Feb 10, 2023

Conversation

engyebrahim
Copy link
Member

fix: #1320 and #676

@engyebrahim
add tests
e5b5740
@engyebrahim
Revert "add tests"
ba6500d 
This reverts commit e5b5740.
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
d17a9f0
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
2fa3202
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
403fb59
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
d3726f4
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
407efd9
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
9daa7fb
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
405d426
@engyebrahim
Merge remote-tracking branch 'microsoft/main'
6685113
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
cd5cff9
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
94ba876
@engyebrahim
update doc
e798040
@engyebrahim
update the msg
da1ea53
@engyebrahim
fix
1fffc7d
@engyebrahim
fix
a9ec5b8
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
5362a00
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
3c2ec83
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
f79a8f2
@engyebrahim
fix
95ec1e3
@engyebrahim
fix
469725c
@engyebrahim
Merge branch 'main' of https://github.com/engyebrahim/testfx
9854250
@engyebrahim
Merge branch 'main' of https://github.com/microsoft/testfx
481e067
@engyebrahim
update doc for deploymentItem
97829c3
@Evangelink
Copy link
Member

@engyebrahim I don't understand how this PR solves #676. My understanding is that people where using .testsettings (e.g. legacy configuration file) which isn't supported by MSTest. I feel like the issue should be simply closed.

@Evangelink Evangelink enabled auto-merge (squash) February 10, 2023 09:03
@Evangelink Evangelink merged commit 7338373 into microsoft:main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation for [DeploymentItem] attribute.
2 participants
@engyebrahim @Evangelink