-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding warning that AssemblyResolution works only with netframworks #1669
Adding warning that AssemblyResolution works only with netframworks #1669
Conversation
src/Adapter/MSTestAdapter.PlatformServices/Services/MSTestAdapterSettings.cs
Outdated
Show resolved
Hide resolved
src/Adapter/MSTestAdapter.PlatformServices/Services/MSTestAdapterSettings.cs
Outdated
Show resolved
Hide resolved
src/Adapter/MSTestAdapter.PlatformServices/Services/MSTestAdapterSettings.cs
Outdated
Show resolved
Hide resolved
@@ -127,6 +128,17 @@ public static MSTestAdapterSettings ToSettings(XmlReader reader) | |||
return settings; | |||
} | |||
|
|||
public static void ValidateSettings(IMessageLogger logger) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it need to be public
? Can it be internal
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when I do it protected I can't call it from the MSTestSettings
class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I said internal not protected :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry my bad
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still public
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ValidateSettings func and the class we are using it inside are in different projects can't make it internal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more changes and we will be good to merge
src/Adapter/MSTestAdapter.PlatformServices/Services/MSTestAdapterSettings.cs
Outdated
Show resolved
Hide resolved
src/Adapter/MSTestAdapter.PlatformServices/Services/MSTestAdapterSettings.cs
Outdated
Show resolved
Hide resolved
@@ -127,6 +128,17 @@ public static MSTestAdapterSettings ToSettings(XmlReader reader) | |||
return settings; | |||
} | |||
|
|||
public static void ValidateSettings(IMessageLogger logger) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still public
fix: #1645