Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataSourceAttribute Implementation #238

Merged
merged 8 commits into from
Sep 1, 2017

Conversation

jayaranigarg
Copy link
Member

No description provided.

@msftclas
Copy link

@jayaranigarg,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@jayaranigarg
Copy link
Member Author

@harshjain2 : please have a look....

/// <summary>
/// The test initialize attribute.
/// </summary>
[AttributeUsage(AttributeTargets.Method, AllowMultiple = false)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit : formatting.

@@ -55,21 +57,18 @@ public class TestMethodInfo : ITestMethod
/// </summary>
public bool IsRunnable => string.IsNullOrEmpty(this.NotRunnableReason);

/// <inheritdoc/>
public ParameterInfo[] ParameterTypes => this.TestMethod.GetParameters();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removed /// <inheritdoc/>?

Copy link
Contributor

@AbhitejJohn AbhitejJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See if more tests are needed and confirm with Pratap on the behavior of having DS and ITDS together.

watch.Stop();
var failedResult = new UTF.TestResult();
failedResult.Outcome = UTF.UnitTestOutcome.Error;
failedResult.TestFailureException = ex;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would move inside the foreach.

@jayaranigarg jayaranigarg merged commit d5d78f0 into microsoft:master Sep 1, 2017
@jayaranigarg jayaranigarg deleted the datasourceimpl branch December 8, 2017 08:38
@jayaranigarg jayaranigarg restored the datasourceimpl branch December 27, 2017 09:24
@jayaranigarg jayaranigarg deleted the datasourceimpl branch May 14, 2018 06:46
@cactuaroid
Copy link

@jayaranigarg, thank you for the works. Now DataTestMethodAttribute looks same as TestMethodAttribute. Which should I specify with DataRowAttribute? No explicit guideline is found on reference.

Could you put some explanations on DataTestMethodAttribute ?

DataTestMethodAttribute has been included since initial commit. DataTestMethodAttribute seems to be integrated into TestMethodAttribute in your commit. I think DataTestMethodAttribute is now obsolete and just for backward compatibility.

DataRowAttribute example uses TestMethodAttribute, whereas this example uses DataTestMethodAttribute.

I found the same confusion here.
https://stackoverflow.com/questions/46904953/datatestmethod-vs-testmethod

@jayaranigarg
Copy link
Member Author

@cactuaroid : Can you please open a new issue for this question? I would not encourage you to ask questions on threads/pull requests which have been closed.

@cactuaroid
Copy link

@jayaranigarg, I'm sorry about that, I have posted #614. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants