-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataSourceAttribute Implementation #238
Conversation
@jayaranigarg, |
@harshjain2 : please have a look.... |
/// <summary> | ||
/// The test initialize attribute. | ||
/// </summary> | ||
[AttributeUsage(AttributeTargets.Method, AllowMultiple = false)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit : formatting.
@@ -55,21 +57,18 @@ public class TestMethodInfo : ITestMethod | |||
/// </summary> | |||
public bool IsRunnable => string.IsNullOrEmpty(this.NotRunnableReason); | |||
|
|||
/// <inheritdoc/> | |||
public ParameterInfo[] ParameterTypes => this.TestMethod.GetParameters(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removed /// <inheritdoc/>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See if more tests are needed and confirm with Pratap on the behavior of having DS and ITDS together.
watch.Stop(); | ||
var failedResult = new UTF.TestResult(); | ||
failedResult.Outcome = UTF.UnitTestOutcome.Error; | ||
failedResult.TestFailureException = ex; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would move inside the foreach.
@jayaranigarg, thank you for the works. Now Could you put some explanations on DataTestMethodAttribute ?
DataRowAttribute example uses I found the same confusion here. |
@cactuaroid : Can you please open a new issue for this question? I would not encourage you to ask questions on threads/pull requests which have been closed. |
@jayaranigarg, I'm sorry about that, I have posted #614. Thank you. |
No description provided.