Throwing exception only if it is of type TestPlatformFormatException #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-bot test Windows / Debug Build |
abhishkk
reviewed
Dec 15, 2017
| throw ex.InnerException; | ||
| // In case of UWP .Net Native Tool Chain compilation. Invoking methods via Reflection doesn't work, hence discovery always fails. | ||
| // Hence throwing exception only if it is of type TestPlatformFormatException | ||
| if (ex.InnerException is TestPlatformFormatException) |
There was a problem hiding this comment.
AFAIK platform throws only testplatformformatexception, but instead of relying entirely on this fact, we can skip exception specifically when it is thrown because of reflection not working. In other cases, lets throw error.
Skipping all exceptions other than testplatformformatexception might skip unexpected exceptions in addition to reflection related exception.
There was a problem hiding this comment.
In case any other exception is thrown, which is very unlikely, we should continue with discovery rather than not doing at all, because platform went wrong, which is why I'm only throwing error if it platform exception
abhishkk
approved these changes
Dec 15, 2017
jayaranigarg
approved these changes
Dec 15, 2017
Merged
mayankbansal018
added a commit
that referenced
this pull request
Apr 3, 2018
* Fixing Key collision for test run parameters (#328) * Base commit * Adding Unit Test * PR comments * Adding logs for diagnostics * Ignoring Test Temporarily * Removing ignore # Conflicts: # test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Execution/TestExecutionManagerTests.cs * Fixing the copyright in the nuspec files. (#350) * Today even if classInit wasnt called we used to call class cleanup. f… (#372) * Today even if classInit wasnt called we used to call class cleanup. fixing that and adding a test to cover the scenario # Conflicts: # src/Adapter/MSTest.CoreAdapter/Execution/TestClassInfo.cs * [Symbol archiving]Converting Portable pdb to full (#375) * COnverting portable pdbs to full for Symbol archiving * Fixing nuget package path * Test fix * Indent fix * Update Fileversion for adapter and framework dlls (#337) * File version update * Moving to 15.6 * PR comments * More PR comments * Throwing exception only if it is of type TestPlatformFormatException (#332) * Throwing exception only if it is of type TestPlatformFormatException * test * Fail discovery if any exception thrown in IDiscoveryContext.GetTestCaseFilter * Fix masking assembly load faolure error message (#382) # Conflicts: # src/Adapter/MSTest.CoreAdapter/Discovery/AssemblyEnumeratorWrapper.cs
singhsarab
pushed a commit
to singhsarab/testfx
that referenced
this pull request
Apr 8, 2019
* Fix assembly loading in symbol loader. (microsoft#332) Instead of attempting to load the test assembly, try to query for it. It should have been already loaded by the test adapter. In netcoreapp1.1, attempting to load the same executable within itself throws. * Add error tracing for symbol parse failure. * Fix platform tests for objectmodel. * Fix debug type. Copy manifest file and comcomponents to output directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.