Added an option to deploy all files in the test source location #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dlls by default. This option will be on by default. It can turned off in which case deployment would just deploy the test source location and skip the test results folder if the test results folder is within it. Added UTs and E2E tests for the change
cltshivash
commented
Mar 27, 2018
test/UnitTests/PlatformServices.Desktop.Unit.Tests/Utilities/DeploymentUtilityTests.cs
Outdated
Show resolved
Hide resolved
cltshivash
commented
Mar 27, 2018
test/UnitTests/PlatformServices.Desktop.Unit.Tests/Utilities/DeploymentUtilityTests.cs
Outdated
Show resolved
Hide resolved
singhsarab
reviewed
May 9, 2018
singhsarab
reviewed
May 9, 2018
singhsarab
approved these changes
May 11, 2018
jayaranigarg
approved these changes
May 11, 2018
| @@ -116,6 +57,7 @@ public static MSTestAdapterSettings ToSettings(XmlReader reader) | |||
| // | |||
| // <MSTestV2> | |||
| // <DeploymentEnabled>true</DeploymentEnabled> | |||
| // <DeployTestSourceDependencies>true</DeployTestSourceDependencies> | |||
| @@ -91,14 +92,14 @@ internal bool IsValidDeploymentItem(string sourcePath, string relativeOutputDire | |||
| return false; | |||
| } | |||
|
|
|||
| if (sourcePath.IndexOfAny(System.IO.Path.GetInvalidPathChars()) != -1 || | |||
| relativeOutputDirectory.IndexOfAny(System.IO.Path.GetInvalidPathChars()) != -1) | |||
| if (sourcePath.IndexOfAny(Path.GetInvalidPathChars()) != -1 || | |||
| using System.Threading.Tasks; | ||
| using Microsoft.VisualStudio.TestPlatform.MSTestAdapter.PlatformServices.Deployment; | ||
|
|
||
| internal class DeploymentResult |
There was a problem hiding this comment.
Adding comments summarizing purpose of this class would be good.
src/Adapter/PlatformServices.Desktop/Utilities/DeploymentUtility.cs
Outdated
Show resolved
Hide resolved
|
Please put up an RFC in testfx-docs describing the usage of this 'DeployTestSourceDependencies' flag and link that to this PR. |
|
@cltshivash : Please complete this PR. |
|
@cltshivash : Can we get this PR in? It will solve this issue #490 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to deploy the test source dependencies and satellite dlls by default (DeployTestSourceDependencies) in addition to the content of the test source directory (bin/debug of the test dll). This option will be on by default for compat reasons.
It can be turned off in which case deployment would only deploy the files from the test source location.
Added UTs and E2E tests for the change