Allow Task-returning test methods without async keyword #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables asynchronous tests that don't use the async state machine while still rejecting async void methods.
|
|
mayankbansal018
approved these changes
Nov 5, 2018
|
@AbhitejJohn , @jayaranigarg do you guys see any issue with this change? |
AbhitejJohn
approved these changes
Nov 7, 2018
|
@spanglerco , @mayankbansal018 : Looks good to me. Looks like this also change Assembly/Class/Test Init/Cleanup. Please make sure that any documentation related is updated as well. |
|
@AbhitejJohn thanks for looking into. Will get the documentation updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables asynchronous tests that don't use the async state machine while
still rejecting async void methods.
Fixes #500. Discussion on the issue hasn't concluded whether this behavior is intentional or not, but it was requested that I go ahead and open a pull request for it.