Fix build script to work with VS2019 #641
Conversation
|
@jimmylewis The changes seem to have broken the build. Can you please take a look |
|
@singhsarab is there a way to rerun the build with verbose logging enabled? I can't reproduce the failure locally, and I see that build.ps1 prints a lot of verbose steps that might help me track it down easier. |
The main change is to try to find msbuild using the 'Current' version instead of the '15.0' version. The MSBuild team has stated that 'Current' will be used going forward to avoid a breaking change to the path when the version revs. Also necessary in this change was to drop the /toolsVersion flag from msbuild. It was passing 15.0 but that tools version is not recognized in the current MSBuild. Lastly, added the UWP.Support component as a required build component. When the build targets an instance of VS missing this feature, the build will fail when trying to find Microsoft.Windows.UI.Xaml.CSharp.Targets.
jimmylewis
force-pushed
the
fixBuildVS2019
branch
from
0b7ae3e
to
f9697fb
Compare
| @@ -117,6 +128,7 @@ function Locate-VsInstallPath($hasVsixExtension ="false"){ | |||
|
|
|||
| $requiredPackageIds += "Microsoft.Component.MSBuild" | |||
| $requiredPackageIds += "Microsoft.Net.Component.4.6.TargetingPack" | |||
| $requiredPackageIds += "Microsoft.VisualStudio.Windows.Build" | |||
There was a problem hiding this comment.
$requiredPackageIds += "Microsoft.VisualStudio.Windows.Build" [](start = 1, length = 62)
can you help me understand why this package is required?
There was a problem hiding this comment.
scripts/build/TestFx.targets contains:
<Import Project="$(MSBuildExtensionsPath)\Microsoft\WindowsXaml\v$(VisualStudioVersion)\Microsoft.Windows.UI.Xaml.CSharp.targets" Condition="$(TargetPlatformIdentifier) == 'UAP'" />
This targets file is part of the Microsoft.VisualStudio.Windows.Build component. I ran into this because I have two instances of VS installed but the "latest" one has a very limited set of components. The build script selected it because it was installed more recently and matched the other two component IDs, but the build failed because it couldn't find the targets file.
The main change is to try to find msbuild using the 'Current' version
instead of the '15.0' version. The MSBuild team has stated that
'Current' will be used going forward to avoid a breaking change to the
path when the version revs.
Also necessary in this change was to drop the /toolsVersion flag from
msbuild. It was passing 15.0 but that tools version is not recognized in the
current MSBuild.
Lastly, added the UWP.Support component as a required build component.
When the build script picks an instance of VS missing this feature, the build
will fail when trying to import Microsoft.Windows.UI.Xaml.CSharp.Targets.