Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty C_Cpp.default.compilerPath/includePath doesn't work #2584

Closed
sean-mcmanus opened this issue Oct 1, 2018 · 3 comments
Closed

Empty C_Cpp.default.compilerPath/includePath doesn't work #2584

sean-mcmanus opened this issue Oct 1, 2018 · 3 comments
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. help wanted Can be fixed in the public (open source) repo. Language Service quick fix
Milestone
October 2018

Comments

@sean-mcmanus
Copy link
Collaborator

Using

"C_Cpp.default.compilerPath": "",
"C_Cpp.default.includePath": []

isn't working as expected. Do any other users care about this bug?
@sean-mcmanus sean-mcmanus added this to the Triage milestone Oct 1, 2018
@bobbrow bobbrow added quick fix help wanted Can be fixed in the public (open source) repo. labels Oct 1, 2018
@rei2hu
Copy link

rei2hu commented Oct 2, 2018 •
edited
Loading

I'll try to do this.

Edit: I'm not sure what's wrong with "C_Cpp.default.includePath": []. When I provide it in .vscode/settings.json, I see the configuration have an empty array which I assume is correct.

@rei2hu rei2hu mentioned this issue Oct 2, 2018
Closed
@bobbrow
Copy link
Member

bobbrow commented Oct 2, 2018

I actually started a branch with a fix for this yesterday. I just didn't have time to test it.
https://github.com/Microsoft/vscode-cpptools/tree/bobbrow/bug2584

@rei2hu
Copy link

rei2hu commented Oct 2, 2018

That's good, I already closed my PR.

I tested your branch and it seems to be working so far.

@bobbrow bobbrow added the fixed Check the Milestone for the release in which the fix is or will be available. label Oct 2, 2018
@bobbrow bobbrow modified the milestones: Triage, October 2018 Oct 2, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. help wanted Can be fixed in the public (open source) repo. Language Service quick fix
Projects
None yet
Milestone
October 2018
Development

No branches or pull requests
3 participants
@rei2hu @bobbrow @sean-mcmanus