Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely crashes every time I try to add nodejs/src to includePath #2987

Closed
trulysinclair opened this issue Jan 1, 2019 · 5 comments
Closed
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service more info needed The issue report is not actionable in its current state quick fix
Milestone

Comments

@trulysinclair
Copy link

Type: LanguageService

Describe the bug

  • OS and Version: Windows 10
  • VS Code Version: 1.30.1
  • C/C++ Extension Version: 0.20.1
  • Other extensions you installed (and if the issue persists after disabling them):
  • Developing nodejs addons, I tried to add the nodejs/src directory to access the node.h and other header files and was met with crashes nonstop. I tried "C:/NodeJS/src/" which didn't work. So I tried "C://NodeJS//src//" and it crashed.

Expected behavior
Directory and header files are loaded.

@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Jan 1, 2019

What crashes? What error do you see? Where is this path being used? Is this a bug with VS Code or the C/C++ extension?

Using "//" should never be a valid path. Maybe you meant "\\"? Our extension should normally accept "/" (or \\) in paths. It's possible we have a problem with "//" since that is unexpected input.

@sean-mcmanus sean-mcmanus added bug Language Service more info needed The issue report is not actionable in its current state labels Jan 1, 2019
@trulysinclair
Copy link
Author

I got it to work thankfully. However, I used the wrong slash and that's what crashed it. Specifically, using "//" will cause the server to restart 5 times and Ultimately fail. Forcing you to restart VS Code entirely. So although it was my mistake, I do recommend trying to find out why "//' causes such a crash.

@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Jan 2, 2019

Where did you add the path with "//"? I found/fixed a crash when "//" is used with "//**" in includePath. Is that the same one you hit?

@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Jan 2, 2019
@sean-mcmanus sean-mcmanus added this to the December 2018 milestone Jan 2, 2019
@sean-mcmanus
Copy link
Collaborator

Our latest 0.21.0-insiders3 has fixed the crash when "//" is used.

Setting C_Cpp.updateChannel to "Insiders" is another way to get the update.

@trulysinclair
Copy link
Author

Sorry for such a late response. Yes that's what seemed to crash it pretty hard.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service more info needed The issue report is not actionable in its current state quick fix
Projects
None yet
Development

No branches or pull requests

2 participants