Initial implementation for supporting vcpkg #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbrow
requested changes
Apr 26, 2018
| }; | ||
| } | ||
| } | ||
| catch(error) {} |
There was a problem hiding this comment.
catch should set this.vcpkgPathReady = true and call this.handleConfigurationChange() so that we don't get stuck forever waiting for data that's never coming. #Closed
There was a problem hiding this comment.
Ah yeah. But a finally would be better for this, no? We need to call these two operations no matter what. #Closed
bobbrow
reviewed
Apr 26, 2018
| } | ||
| if (!settings.defaultDefines) { | ||
| configuration.defines = (process.platform === 'win32') ? ["_DEBUG", "UNICODE", "_UNICODE"] : []; | ||
| } | ||
| if (!settings.defaultBrowsePath) { | ||
| // We don't add system includes to the browse.path anymore. The language server has this information. |
There was a problem hiding this comment.
can you add this comment back to the block where you update the browse.path? #Closed
sean-mcmanus
approved these changes
Apr 26, 2018
bobbrow
approved these changes
Apr 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.