Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using sh instead of bash #2340

Merged
merged 2 commits into from
Jul 30, 2018
Merged

Using sh instead of bash #2340

merged 2 commits into from
Jul 30, 2018

Conversation

andyneff
Copy link
Contributor

Fixes #569

sean-mcmanus
sean-mcmanus approved these changes Jul 30, 2018
View reviewed changes
Copy link
Collaborator

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, but the debugger guys should approve as well.

WardenGnaw
WardenGnaw requested changes Jul 30, 2018
View reviewed changes
Copy link
Member

@WardenGnaw WardenGnaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking for testing.

@WardenGnaw WardenGnaw merged commit c36eb8e into microsoft:master Jul 30, 2018
@timedroid
Copy link

This broke debugging for me: #2473

@pieandcakes pieandcakes mentioned this pull request Aug 31, 2018
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@WardenGnaw WardenGnaw WardenGnaw approved these changes

@sean-mcmanus sean-mcmanus sean-mcmanus approved these changes

@pieandcakes pieandcakes Awaiting requested review from pieandcakes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getRemoteOSAndProcesses uses bash
4 participants
@andyneff @timedroid @WardenGnaw @sean-mcmanus