Configuration UI #3479
Merged
Configuration UI #3479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
michelleangela
commented
Apr 16, 2019
michelleangela
commented
- add a configuration UI to edit certain IntelliSense properties
- add command palettes to either open configuration in UI or JSON
- add command to open configuration in UI or JSON from toast notification
- add telemetry to new commands
- inherit workbench.settings.editor settings from VS Code to determine whether the configuration UI or JSON is opened by default
…de-cpptools into dev/coleng/configUI
michelleangela
commented
Apr 16, 2019
bobbrow
requested changes
Apr 17, 2019
WardenGnaw
reviewed
Apr 17, 2019
|
This is what the configuration UI looks like without styling. I will add styling on a separate pull request after this one is checked-in.
|
bobbrow
approved these changes
Apr 17, 2019
| @@ -1,7 +1,8 @@ | |||
| { | |||
| "c_cpp.command.configurationSelect.title": "Select a configuration...", | |||
| "c_cpp.command.configurationProviderSelect.title": "Change configuration provider...", | |||
| "c_cpp.command.configurationEdit.title": "Edit configurations...", | |||
| "c_cpp.command.configurationEditJSON.title": "Edit configurations... (JSON)", | |||
There was a problem hiding this comment.
@michelleangela I think the "..." are always supposed to be at the end of the command text, e.g. "Edit configurations (JSON)…"
|
missing fields:
|
|
Thanks for the feedback @aenima1891. Those properties didn't make the cut for the first version of the UI. We are currently designing the UI for what we term the "advanced" properties for a subsequent update (perhaps the June release). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.